Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update translation : hi, bn, mr #551

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update translation : hi, bn, mr #551

wants to merge 3 commits into from

Conversation

prem-k-r
Copy link
Collaborator

📝 Description

Missed some in urdu, added them
Deleted added texts in hi, bn, mr wrt en

📸 Screenshots / 📹 Videos

image

✅ Checklist

  • I have read and followed the Contributing Guidelines.
  • I have tested my changes by installing them as an extension (not just running via localhost) to ensure it builds, installs, and works as expected.
  • I have tested these changes in at least Chrome and Firefox (other browsers if applicable).
  • Attached visual evidence of changes (screenshots or videos) if applicable.

@prem-k-r prem-k-r added the i18n / l10n Related to Globalization label Feb 23, 2025
@prem-k-r prem-k-r requested a review from itz-rj-here February 23, 2025 15:36
@itz-rj-here itz-rj-here added the changes required PR requires updates based on review feedback label Feb 23, 2025
@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Feb 23, 2025 •
edited
Loading

Comment not pushed @itz-rj-here
Probably agreeText translation? I was not sure which one to keep

@itz-rj-here
Copy link
Collaborator

Comment not pushed @itz-rj-here

I'm on my phone. You have to edit it yourself or I might be able to make changes tomorrow.

@prem-k-r
Copy link
Collaborator Author

We can't see your review comment.. you haven't clicked on finish.
I'll change if you tell where and what

@itz-rj-here
Copy link
Collaborator

Screenshot_2025-02-24-07-14-01-894_com.github.android.jpg

@prem-k-r @itz-rj-here
Update bn.js
f54fda8 
Co-authored-by: It'z RJ <[email protected]>
@prem-k-r prem-k-r removed the changes required PR requires updates based on review feedback label Feb 24, 2025
@prem-k-r
Copy link
Collaborator Author

Screenshot_2025-02-24-07-14-01-894_com.github.android.jpg

See it's showing "Pending", after you click on "FINISH YOUR REVIEW" then it will be posted :)

@prem-k-r prem-k-r requested review from itz-rj-here and removed request for itz-rj-here February 24, 2025 05:23
@itz-rj-here itz-rj-here added the ready to merge The pull request is ready to merge label Feb 24, 2025
@prem-k-r prem-k-r changed the title l10n: Update translation Update translation : hi, bn, mr Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itz-rj-here itz-rj-here itz-rj-here approved these changes

Assignees
No one assigned
Labels
i18n / l10n Related to Globalization ready to merge The pull request is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prem-k-r @itz-rj-here