Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]Search radio button hide delay #559

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

vchib1
Copy link

@vchib1 vchib1 commented Feb 27, 2025

📝 Description

  • Fixed radio button delayed animation when hiding search engines.
  • Reduced radio toggle size to 16px for more cleaner UI.

📸 Screenshots / 📹 Videos

New.Tab.Mozilla.Firefox.2025-02-27.15-07-54.mp4

🔗 Related Issues

  • Closes #<issue_number>
  • Related to #<issue_number> (optional)

✅ Checklist

  • I have read and followed the Contributing Guidelines.
  • I have tested my changes by installing them as an extension (not just running via localhost) to ensure it builds, installs, and works as expected.
  • I have tested these changes in at least Chrome and Firefox (other browsers if applicable).
  • Attached visual evidence of changes (screenshots or videos) if applicable.

@prem-k-r prem-k-r added the bug fixes If there is any problem there this will fix it label Feb 27, 2025
itz-rj-here
itz-rj-here previously approved these changes Feb 27, 2025
@itz-rj-here itz-rj-here added the ready to merge The pull request is ready to merge label Feb 27, 2025
Copy link
Collaborator

@prem-k-r prem-k-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Radio buttons size seems too small to me

@vchib1
Copy link
Author

vchib1 commented Feb 27, 2025

I think their size should be close to the height of the text. The default size looks way bigger to me.

@prem-k-r
Copy link
Collaborator

I'd suggest something like:
image

@prem-k-r prem-k-r added changes required PR requires updates based on review feedback and removed ready to merge The pull request is ready to merge labels Feb 27, 2025
@prem-k-r prem-k-r removed the changes required PR requires updates based on review feedback label Feb 28, 2025
Copy link
Collaborator

@prem-k-r prem-k-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@prem-k-r prem-k-r added ready to merge The pull request is ready to merge ui Styling, layout, spacing, or visual design improvements labels Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fixes If there is any problem there this will fix it ready to merge The pull request is ready to merge ui Styling, layout, spacing, or visual design improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants