This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
build: warn on missing virtual on base class destructor #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
requested review from
acelyc111,
hycdong,
levy5307,
foreverneverer,
Smityz and
zhangyifan27
|
LGTM |
neverchanje
added
the
thirdparty-modified
acelyc111
previously approved these changes
Jun 17, 2021
|
@neverchanje need update pre-built third-parties |
neverchanje
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option is to prevent further issues like #841
Boost 1.69 has the same errors if this option is turned on. If the reviewers have agreed, we can use a newer version of boost, 1.71 for example (which is the default on ubuntu20.04), then this PR can pass.