[AIE2P] Legalization and instruction selection support for G_FADD/G_FSUB #274
+315
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katerynamuts
requested review from
abhinay-anubola,
abnikant,
andcarminati,
gbossu,
khallouh,
konstantinschwarz,
martien-de-jong,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
katerynamuts
force-pushed
the
katemuts.fadd_fsub
branch
2 times, most recently
from
42b9ded to
213e9de
Compare
|
|
||
|
|
||
| --- | ||
| name: test_fadd_bfloat16 |
There was a problem hiding this comment.
this requires name change.
There was a problem hiding this comment.
so do rest of the tests.
| ; AIE2P-NEXT: [[UV2:%[0-9]+]]:_(<16 x s32>), [[UV3:%[0-9]+]]:_(<16 x s32>) = G_UNMERGE_VALUES [[UV]](<32 x s32>) | ||
| ; AIE2P-NEXT: [[INT:%[0-9]+]]:_(<16 x s16>) = G_INTRINSIC_W_SIDE_EFFECTS intrinsic(@llvm.aie2p.v16accfloat.to.v16bf16), [[UV2]](<16 x s32>) | ||
| ; COMMON-NEXT: [[AIE_SEXT_EXTRACT_VECTOR_ELT32:%[0-9]+]]:_(s32) = G_AIE_SEXT_EXTRACT_VECTOR_ELT [[INT]](<16 x s16>), [[C1]](s32) | ||
| ; COMMON-NEXT: [[ASSERT_SEXT:%[0-9]+]]:_(s32) = G_ASSERT_SEXT [[AIE_SEXT_EXTRACT_VECTOR_ELT32]], 16 | ||
| ; COMMON-NEXT: $r0 = COPY [[ASSERT_SEXT]](s32) | ||
| ; COMMON-NEXT: PseudoRET implicit $lr, implicit $r0 | ||
| %0:_(s32) = COPY $r1 |
There was a problem hiding this comment.
Can you add a couple of tests for vectors, for ex. <16 x s32> , same for fadd..
katerynamuts
force-pushed
the
katemuts.fadd_fsub
branch
from
213e9de to
58f0592
Compare
katerynamuts
force-pushed
the
katemuts.fadd_fsub
branch
from
58f0592 to
a917ed9
Compare
katerynamuts
force-pushed
the
katemuts.fadd_fsub
branch
from
a917ed9 to
925fb1a
Compare
katerynamuts
force-pushed
the
katemuts.fadd_fsub
branch
from
925fb1a to
864e264
Compare
katerynamuts
force-pushed
the
katemuts.fadd_fsub
branch
from
864e264 to
b8f9873
Compare
mludevid
force-pushed
the
katemuts.fadd_fsub
branch
from
b8f9873 to
466ccb8
Compare
mludevid
force-pushed
the
katemuts.fadd_fsub
branch
from
466ccb8 to
dedcc6b
Compare
|
I've updated the legalization commit. It now legalizes the non-vector case properly. I've also split up the test for vectors on aie2 and aie2p, because the two architectures perform the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.