[AIE2P] Add support for multislot FIFO loads #330
Merged
+1,102
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andcarminati
requested review from
abhinay-anubola,
abnikant,
F-Stuckmann,
gbossu,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
niwinanto,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
| # (c) Copyright 2025 Advanced Micro Devices, Inc. or its affiliates | ||
| # RUN: llc -march=aie2p -run-pass=postmisched %s -o - | FileCheck %s | ||
|
|
||
| # This test checks that we are scheduling mulislot loads from differnt banks in on VLIW bundle. |
There was a problem hiding this comment.
nit: multislot ; different; one
| # This test checks that we are scheduling mulislot loads from differnt banks in on VLIW bundle. | ||
|
|
||
| --- | ||
| name: VLD_FILL_512_pseudo_same |
There was a problem hiding this comment.
nit: same memory bank, not same bundle. That's confusing with the comment right above.
| ; CHECK-NEXT: [[VLDB_FILL_512_:%[0-9]+]]:eps, [[VLDB_FILL_512_1:%[0-9]+]]:eldfiforeg, [[VLDB_FILL_512_2:%[0-9]+]]:erf2 = VLDB_FILL_512 [[DEF]], [[DEF1]], [[DEF2]] | ||
| ; CHECK-NEXT: PseudoRET implicit $lr, implicit [[VLDB_FILL_512_]], implicit [[VLDB_FILL_512_1]], implicit [[VLDB_FILL_512_2]] | ||
| ; CHECK-NEXT: [[VLD_FILL_512_pseudo:%[0-9]+]]:eps, [[VLD_FILL_512_pseudo1:%[0-9]+]]:eldfiforeg, [[VLD_FILL_512_pseudo2:%[0-9]+]]:erf2 = VLD_FILL_512_pseudo [[DEF]], [[DEF1]], [[DEF2]] | ||
| ; CHECK-NEXT: PseudoRET implicit $lr, implicit [[VLD_FILL_512_pseudo]], implicit [[VLD_FILL_512_pseudo1]], implicit [[VLD_FILL_512_pseudo2]] |
There was a problem hiding this comment.
Would be nice if we would have a pass 'expand-pseudo-to-first-alternative' that we could run in this test.
There was a problem hiding this comment.
But we are testing the instruction-select pass, so I think it makes sense to test the new opcodes
andcarminati
force-pushed
the
andreu.multislot.vld
branch
from
d78e1ff to
e4c971a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All remaining VLD operations will be handled in a follow-up PR.