Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup code #47

Merged
merged 1 commit into from
May 30, 2024
Merged

Startup code #47

merged 1 commit into from
May 30, 2024

Conversation

mchokshi091101
Copy link
Collaborator

  • Rebased Startup Code PR
  • Added _Exit() function in crt1.cc

foreach(target IN LISTS startup_components)
set(fq_target_name libc.startup.baremetal.${target})
add_dependencies(libc-startup ${fq_target_name})
install(FILES $<TARGET_OBJECTS:${fq_target_name}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until we update to the most recent libc build system, we need to add the following to fix the build & install targets of the startup files:

diff --git a/libc/lib/CMakeLists.txt b/libc/lib/CMakeLists.txt
index 652ebc9ffb46..cffe47dbf931 100644
--- a/libc/lib/CMakeLists.txt
+++ b/libc/lib/CMakeLists.txt
@@ -41,6 +41,9 @@ foreach(archive IN ZIP_LISTS
   # with custom targets and in older version of cmake (~pre-3.20, apparently)
   # there is not good support for describing install dependencies on custom targets.
   add_dependencies(${archive_1} libc-headers)
+  if(TARGET libc-startup)
+    add_dependencies(${archive_1} libc-startup)
+  endif()
 
   set_target_properties(
     ${archive_1}

Copy link
Collaborator

@konstantinschwarz konstantinschwarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits during rebase&merge

@SagarMaheshwari99 SagarMaheshwari99 merged commit 7304a57 into Xilinx:aie-public May 30, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants