Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[asplos] capitalization fixes on mlir/prime_sieve_large example #1398

Closed
wants to merge 3 commits into from

Conversation

efurst
Copy link
Contributor

@efurst efurst commented Apr 24, 2024

No description provided.

@jgmelber jgmelber changed the base branch from asplos to main April 25, 2024 02:20
@jgmelber jgmelber changed the base branch from main to asplos April 25, 2024 02:20
@jgmelber
Copy link
Collaborator

This looks good to me! Can you rebase this on main? We merged asplos into main and are working there now.

Copy link
Collaborator

@AndraBisca AndraBisca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these fixes! Like Joe mentioned, please rebase this PR to main.

@efurst
Copy link
Contributor Author

efurst commented Apr 25, 2024

The rebase ended up being a mess, so I created a new branch and cherry-picked commits from this PR and #1402
The new updated PR is #1417
Please feel free to close this PR!

@denolf
Copy link
Collaborator

denolf commented Apr 25, 2024

Closed per Emily's request. New updated PR is #1417

@denolf denolf closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants