Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump llvm #1455

Merged
merged 2 commits into from
May 3, 2024
Merged

bump llvm #1455

merged 2 commits into from
May 3, 2024

Conversation

fifield
Copy link
Collaborator

@fifield fifield commented May 3, 2024

update llvm to 1cde124
account for expand_shape changes

@jsetoain
Copy link
Collaborator

jsetoain commented May 3, 2024

Yes, I was going to say. Between the version I originally used to replicate the other issues and the latest one, another change broke another test 😬

@jsetoain
Copy link
Collaborator

jsetoain commented May 3, 2024

Yes, I was going to say. Between the version I originally used to replicate the other issues and the latest one, another change broke another test 😬

@makslevental It looks like we're not running the integration tests any more (the ones activated with -DAIE_INCLUDE_INTEGRATION_TESTS=ON), that's why CI didn't catch the issues.

@jsetoain jsetoain enabled auto-merge (squash) May 3, 2024 17:41
@fifield
Copy link
Collaborator Author

fifield commented May 3, 2024

Yes, I was going to say. Between the version I originally used to replicate the other issues and the latest one, another change broke another test 😬

@makslevental It looks like we're not running the integration tests any more (the ones activated with -DAIE_INCLUDE_INTEGRATION_TESTS=ON), that's why CI didn't catch the issues.

It looks like I wasn't running those tests either. I get a few failures after turning them on.

Failed Tests (7):
  AIE :: Integration/Dialect/TOSA/bf16_ceil_v16/bf16_ceil.mlir
  AIE :: Integration/Dialect/TOSA/bf16_ceil_v32/bf16_ceil.mlir
  AIE :: Integration/Dialect/TOSA/bf16_floor_v16/bf16_floor.mlir
  AIE :: Integration/Dialect/TOSA/bf16_floor_v32/bf16_floor.mlir
  AIE :: Integration/Dialect/TOSA/bf16_sigmoid_v16bf16/bf16_sigmoid.mlir
  AIE :: Integration/Dialect/TOSA/bf16_sigmoid_v32bf16/bf16_sigmoid.mlir
  AIE :: Integration/julia_by_lines/aie.mlir

@jsetoain
Copy link
Collaborator

jsetoain commented May 3, 2024

Yes, I was going to say. Between the version I originally used to replicate the other issues and the latest one, another change broke another test 😬

@makslevental It looks like we're not running the integration tests any more (the ones activated with -DAIE_INCLUDE_INTEGRATION_TESTS=ON), that's why CI didn't catch the issues.

It looks like I wasn't running those tests either. I get a few failures after turning them on.

The same happened to me due to recent dev. env shenanigans. Anyway, the patch I sneaked in right before this one fixes those issues, but it looks like after rebase a test failed. I suspect it was one of those spurious failures we're getting later because the previous run finished successfully, might be worth looking into it.

I forgot, this is the failed attempt: https://github.com/Xilinx/mlir-aie/actions/runs/8942799480/attempts/1?pr=1455

@jsetoain jsetoain merged commit 7302952 into main May 3, 2024
54 checks passed
@jsetoain jsetoain deleted the bump_llvm branch May 3, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants