Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't generate configuration from elfs if elf path wasn't provided #1898

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

fifield
Copy link
Collaborator

@fifield fifield commented Nov 1, 2024

Skip loading the elfs in convert-aie-to-control-packets and convert-aie-to-transaction passes if an elf directory was not provided. Otherwise it'll crash.

Don't generate configuration from elfs if an elf directory was not provided.
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Coverage Report

Created: 2024-11-01 16:58

Click here for information about interpreting this report.

FilenameFunction CoverageLine CoverageRegion CoverageBranch Coverage
home/runner/work/mlir-aie/mlir-aie/lib/Conversion/AIEToConfiguration/AIEToConfiguration.cpp 88.24% 85.08% 77.49% 48.68%
Totals 88.24% 85.08% 77.49% 48.68%
Generated by llvm-cov -- llvm version 14.0.0

@fifield fifield added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit 610a4f8 Nov 1, 2024
52 checks passed
@fifield fifield deleted the no_elfs branch November 1, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant