-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Multi-Dimensional Address Generation to Object Fifo #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actor requiresDMAs
fifield
added a commit
to fifield/mlir-aie
that referenced
this pull request
Nov 8, 2023
* Solve conflicts with upstream commit a2ae91d * Make objectfifo-generated locks and buffers early to avoid SSA domination issue (Xilinx#670) * Add Multi-Dimensional Address Generation to Object Fifo (Xilinx#664) * add multi-dimensional address generation features to objectFifo * do not emit strides/wraps if multi-dim address generation is not used * swap stride and wrap order in ND DMA tuple to be consistent with AIEX.nd_dma_memcpy * add nd-dma documentation * allow for different data layout transformations for each consumer in objectFifo * add early error about architectural stepsize/wrap limitations * fix printer of multi-dim objectFifo; add multi-dim register process test * fix typos; fix objectFifoCreateOp printer for multiple consumers; refactor requiresDMAs * fix broken nd_dma test * Added distribute test case * Working on solving failing .py test. * Generate error when LinkOp is used with objFifos that have to/from Stream dimensions. * register attribute builders for AIE_DimTupleArrayAttr and AIE_DimTupleArrayArrayAttr * Settle on final syntax version for ObjectFifoCreateOp dimensional inputs. * Fixed failing tests. * Fix wrong commit. * Fix python test * Fix failing test. * Clang patch * Fix failing tests --------- Co-authored-by: andrej <[email protected]> Co-authored-by: abisca <[email protected]> Co-authored-by: max <[email protected]> Co-authored-by: Jeff Fifield <[email protected]> Co-authored-by: erwei-xilinx <[email protected]> Co-authored-by: Joseph Melber <[email protected]> Co-authored-by: andrej <[email protected]> Co-authored-by: max <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a branch within Xilinx/milir-aie/main. Comment from original PR #589