Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the L3->L2 channels to distribute data over scf.for #765

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

erwei-xilinx
Copy link
Collaborator

@erwei-xilinx erwei-xilinx commented Nov 8, 2024

Copy link
Contributor

@hunhoffe hunhoffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me once CI passes! Interesting error currently in the CI, not sure what would cause it.

@fifield
Copy link
Collaborator

fifield commented Nov 8, 2024

  • This pattern implies a chain of bds performing time-multiplexed movement of multiple memrefs, operating on one shared DMA channel.

You did this based on your deep knowledge of the compiler. How can we document this and other such patterns so that others can access them?

@erwei-xilinx
Copy link
Collaborator Author

Looks good to me once CI passes! Interesting error currently in the CI, not sure what would cause it.

I think this is reproducing the issue that you previously mentioned in #709. I'm working on a number of pass fixups to generalize some AIR passes to cover this pattern.

@erwei-xilinx
Copy link
Collaborator Author

erwei-xilinx commented Nov 11, 2024

  • This pattern implies a chain of bds performing time-multiplexed movement of multiple memrefs, operating on one shared DMA channel.

You did this based on your deep knowledge of the compiler. How can we document this and other such patterns so that others can access them?

Yes it would be very useful to have proper documentation for users who wish to write designs in AIR using python bindings. I created an issue to keep track of the documentation progress: #770.

@erwei-xilinx erwei-xilinx merged commit 64d05c0 into Xilinx:main Nov 11, 2024
11 checks passed
@erwei-xilinx erwei-xilinx deleted the vecmat_bd_chain_from_scf_for branch November 11, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants