p2p, p2p/discover: add dial metrics #829
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR solved the issue #833
Adding several new metrics to enhance our monitoring capabilities:
p2p/dials/success
: Counts the total number of successful dials resulting in a peer being added.p2p/dials/error/connection
: Tracks errors when initiating a TCP connection to a target.p2p/dials/error/saturated
: Indicates attempts to connect when the local client has reached its maximum peer limit.p2p/dials/error/known
: Logs attempts to dial already connected peers.p2p/dials/error/self
: Records attempts to dial the local node's own ID.p2p/dials/error/useless
: Identifies dials to peers that don't share any capabilities with the local node.p2p/dials/error/id/unexpected
: Captures instances where a dialed peer responds with a different ID than expected.p2p/dials/error/rlpx/enc
: Tracks errors during RLpx encryption negotiation.p2p/dials/error/rlpx/proto
: Logs errors during the RLpx protocol handshake.Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅
in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅
in the boxes that applyChecklist
Put an
✅
in the boxes once you have confirmed below actions (or provide reasons on not doing so) that