Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open source internal implementation #5

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kononovk
Copy link
Member

@kononovk kononovk commented May 27, 2023

Purpose

  • First implementation of all asynchronous primitives.
  • Add tests, examples
  • Fix CI
  • Changes in README (add badges and useful links)

Related Information

  • Design document: ...
  • Bench PR: ...

Testing

  • This change is a trivial rework or code cleanup without any test coverage.
  • This change is already covered by existing tests.
  • This PR adds tests that were used to verify all changes.
  • There are tests in an external testing repository: ...

@kononovk kononovk requested a review from MBkkt as a code owner May 27, 2023 17:30
@kononovk kononovk added devops DevOps tasks enhancement New feature or request labels May 27, 2023
@github-actions
Copy link

Pull Request Test Coverage Report for Build 5099995144

  • 65 of 75 (86.67%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-13.9%) to 86.111%

Changes Missing Coverage Covered Lines Changed/Added Lines %
include/ione/context.hpp 21 23 91.3%
src/context.cpp 33 41 80.49%
Totals Coverage Status
Change from base Build 5009095869: -13.9%
Covered Lines: 113
Relevant Lines: 124

💛 - Coveralls

@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Merging #5 (0b6fd09) into main (8a92d55) will decrease coverage by 13.34%.
The diff coverage is 86.66%.

@@             Coverage Diff              @@
##              main       #5       +/-   ##
============================================
- Coverage   100.00%   86.66%   -13.34%     
============================================
  Files            1        3        +2     
  Lines            2       75       +73     
============================================
+ Hits             2       65       +63     
- Misses           0       10       +10     
Impacted Files Coverage Δ
src/context.cpp 80.48% <80.48%> (ø)
include/ione/context.hpp 91.30% <91.30%> (ø)
include/ione/async/timeout.hpp 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops DevOps tasks enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant