[Refactor/#351] WorkBookSubscriberWriter 책임 분리 리펙토링 #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belljun3395
commented
Aug 18, 2024
Comment on lines
+41
to
+46
| /** 이메일 전송을 위한 데이터 조회 */ | ||
| val memberEmailRecords = browseMemberEmailService.execute(memberIds) | ||
| val workbooksMappedLastDayCol = browseWorkbookLastDayColService.execute(targetWorkBookIds) | ||
| val memberReceiveArticles = | ||
| browseMemberReceiveArticlesService.execute(targetWorkBookProgress) | ||
| val articleContents = browseArticleContentsService.execute(memberReceiveArticles.getArticleIds()) |
There was a problem hiding this comment.
필요한 정보를 조회하는 과정은 browseXXXService로 분리하였습니다.
Comment on lines
+49
to
+55
| val emailServiceArgs = MailServiceArgsGenerator( | ||
| LocalDate.now(), | ||
| items, | ||
| memberEmailRecords, | ||
| memberReceiveArticles, | ||
| articleContents | ||
| ).generate() |
There was a problem hiding this comment.
MailServiceArgsGenerator로 MailServiceArgs를 생성하도록 수정하였습니다.
Comment on lines
+71
to
+83
| /** 이메일 전송 결과에 따라 진행률 업데이트 및 구독 해지 처리를 위한 데이터 생성 */ | ||
| val receiveLastDayRecords = | ||
| ReceiveLastArticleRecordFilter(items, workbooksMappedLastDayCol).filter() | ||
| .map { | ||
| ReceiveLastArticleRecord(it.memberId, it.targetWorkBookId) | ||
| } | ||
|
|
||
| val receiveLastDayMemberIds = receiveLastDayMembers.map { | ||
| it.memberId | ||
| val updateTargetMemberRecords = UpdateProgressRecordFilter( | ||
| items, | ||
| mailSendRecorder.getSuccessMemberIds(), | ||
| receiveLastDayRecords.getMemberIds() | ||
| ).filter().map { | ||
| UpdateProgressRecord(it.memberId, it.targetWorkBookId, it.progress) |
There was a problem hiding this comment.
item에서 원하는 결과만 필터링하는 것ㅇ르 xxxFilter 클래스로 분리하였습니다.
| val targetWorkBookId: Long, | ||
| val progress: Long, | ||
| ) { | ||
| val updatedProgress: Long = progress + 1 |
There was a problem hiding this comment.
해당 값의 경우 프로퍼티가 적절할 것 같아 프로퍼티로 구현하였습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 연관 이슈
resolved: #351
💁♂️ PR 내용
🙏 작업
🙈 PR 참고 사항
📸 스크린샷
🤖 테스트 체크리스트