Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PC-615] 회원 탈퇴 이유 저장 #62

Merged
merged 10 commits into from
Feb 16, 2025

Conversation

devchlee12
Copy link
Member

@devchlee12 devchlee12 commented Feb 15, 2025

🔗 관련 이슈

PC-615

✨ 작업 내용

  • 회원 탈퇴 이유 저장 기능 구현

✅ 체크리스트

  • 코드가 정상적으로 컴파일되나요?
  • 테스트 코드를 통과했나요?
  • merge할 브랜치의 위치를 확인했나요?
  • Label을 지정했나요?

🎃 새롭게 알게된 사항

📋 참고 사항

  • 코드 리뷰 시 논의가 필요한 사항이나 배포 관련 주의 사항을 추가합니다.

@devchlee12 devchlee12 requested a review from Lujaec February 15, 2025 15:46
@devchlee12 devchlee12 self-assigned this Feb 15, 2025
Copy link

github-actions bot commented Feb 15, 2025

Unit Test Results

23 tests   22 ✔️  2s ⏱️
10 suites    0 💤
10 files      1

For more details on these failures, see this check.

Results for commit 52f1584.

♻️ This comment has been updated with latest results.

@@ -36,8 +38,10 @@ public ResponseEntity<CommonResponse<UserRejectHistoryResponse>> getUserRejectHi
@DeleteMapping
@PreAuthorize(value = "hasRole('USER')")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그런데 회원이 아직 프로필 검증 상태일 때는, 회원 탈퇴를 못하는 건가요 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그 부분을 생각 못했네요. 수정하겠습니다!

@devchlee12
Copy link
Member Author

수정 완료했습니다!

@devchlee12 devchlee12 requested a review from Lujaec February 16, 2025 09:34
@devchlee12 devchlee12 merged commit 7015a97 into develope Feb 16, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants