QA/126-signup 회원가입시 약관~ 스낵바 출현하며 가입이 불가한 현상 #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinukeu
reviewed
May 27, 2024
| @@ -96,7 +96,7 @@ class SignUpViewModel @Inject constructor( | |||
| } else { | |||
| null | |||
| }, | |||
| termAgreement = uiState.value.agreedTerms, | |||
| termAgreement = uiState.value.agreedTerms.filter { it > 0 }, | |||
There was a problem hiding this comment.
p2:
it > 0 이 명확하게 어떤 내용인지 감이 잘 안오네요!
추가로 나중에 약관 동의 항목이 더 생기거나 순서가 바뀌면 예상치 못한 동작을 일으킬 것 같습니다!
it 대신 enum class를 사용하고 it > 0 대신 it != (만14세 이상 enum class) 이렇게 바꾸는거 어떠세요!?
There was a problem hiding this comment.
다른 약관은 서버에서 내려주고 있고, 14세 약관만 로컬에서 사용하는 약관이에요
약관 번호로 체크 여부를 판단하느랴 정수형 번호로 부여되어 있어요
회원가입 시 [1, 2]의 array 형태로 동의한 약관의 번호를 보내줍니다
그래서 서버 응답을 굳이굳이 Enum class로 바꾸어 사용하는 방법은 힘들 것 같고..
100번대부터는 로컬에서 사용하는 약관 번호로 사용하는 방법은 어떨까요?
There was a problem hiding this comment.
아하 서버에서 이렇게 하는군요 ...
음 .. 서버 응답값을 바꿔주는게 좋겠어요
오늘 서버쪽이랑 얘기해보죠~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 Key changes
✅ To Reviewers
📸 스크린샷