Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ Fix ] : 해상도에 따라 다이얼로그의 버튼이 짤리는 현상 수정 #330

Merged
merged 1 commit into from
Dec 5, 2023
Merged

[ Fix ] : 해상도에 따라 다이얼로그의 버튼이 짤리는 현상 수정 #330

merged 1 commit into from
Dec 5, 2023

Conversation

toastmeister1
Copy link
Member

Description

  • 이슈가 발생했던 '팀 선택하기' 문구를 -> '선택하기' 로 변경
  • Button의 text가 버튼 너비보다 큰 경우 Ellipsis 를 통해 말줄임표 처리

Screen Shots

Screen Shot Screen Shot

Check List

  • CI/CD 통과여부
  • Develop Mege 시 Squash and Merge 형태로 넣어주세요!
  • 1Approve 이상 Merge
  • Unit Test 작성
  • 연관된 이슈를 PR에 연결해주세요.

@toastmeister1
[ Fix ] : 해상도에 따라 다이얼로그의 버튼이 짤리는 현상 수정
d0047f3 
- 이슈가 발생했던 '팀 선택하기' 문구를 -> '선택하기' 로 변경
- Button의 text가 버튼 너비보다 큰 경우 Ellipsis 를 통해 말줄임표 처리
TaeseongYun
TaeseongYun approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@TaeseongYun TaeseongYun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다
원래 uniform 처럼 처리하려 했는데 문구 변경하는게 더 간단하겠군요

@toastmeister1 toastmeister1 merged commit 79df90b into develop Dec 5, 2023
1 check passed
@toastmeister1 toastmeister1 deleted the fix/pop_up_dialog_button branch December 5, 2023 10:43
@toastmeister1 toastmeister1 linked an issue Jan 15, 2024 that may be closed by this pull request
기기 별로 YDSButton 이 짤려서 보이는 이슈 수정 #320
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TaeseongYun TaeseongYun TaeseongYun approved these changes

@hoyahozz hoyahozz Awaiting requested review from hoyahozz

@jihee-dev jihee-dev Awaiting requested review from jihee-dev

Assignees

@toastmeister1 toastmeister1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

기기 별로 YDSButton 이 짤려서 보이는 이슈 수정
2 participants
@toastmeister1 @TaeseongYun