Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: Flutter 팀 및 직군, APP 팀 추가 대응 #338

Merged
merged 3 commits into from
May 5, 2024

Conversation

jihee-dev
Copy link
Member

@jihee-dev jihee-dev commented May 5, 2024

Description
현재 develop 브랜치에 배포할 수 없는 커밋(세션 정보를 firestore에서 가져오도록 수정하는 코드)이 포함되어 있어 release 브랜치를 타겟으로 작업합니다

  • Flutter 팀 및 직군 추가 대응
  • APP 팀 추가 대응
  • GetMemberAttendanceListUseCase collect -> collectLatest로 변경 (error lines)
  • auto-assign 수정

Screen Shots

Screen Shot Screen Shot

Check List

  • CI/CD 통과여부
  • Develop Mege 시 Squash and Merge 형태로 넣어주세요!
  • 1Approve 이상 Merge
  • Unit Test 작성
  • 연관된 이슈를 PR에 연결해주세요.

@jihee-dev jihee-dev self-assigned this May 5, 2024
@auto-assign auto-assign bot requested a review from TaeseongYun May 5, 2024 06:26
@jihee-dev jihee-dev removed the request for review from TaeseongYun May 5, 2024 06:27
@jihee-dev jihee-dev linked an issue May 5, 2024 that may be closed by this pull request
3 tasks
@jihee-dev jihee-dev changed the title [Fix]: Flutter 팀 및 직군 추가 대응 [Fix]: Flutter 팀 및 직군, APP 팀 추가 대응 May 5, 2024
Copy link
Member

@hoyahozz hoyahozz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👍👍👍

@jihee-dev jihee-dev force-pushed the feature/fix-team-position-crash branch from 8ef4f7d to 4bd4939 Compare May 5, 2024 07:08
@toastmeister1
Copy link
Member

생각 못한부분이였는데 고생하셨어요 지희님
테스트 시 문제 없었습니다~

@jihee-dev jihee-dev merged commit 0b936d9 into release May 5, 2024
@jihee-dev jihee-dev deleted the feature/fix-team-position-crash branch May 5, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flutter 팀 및 직군 대응
3 participants