Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: 출석 인증 시간 변경 #341

Merged
merged 1 commit into from
May 15, 2024
Merged

[Feature]: 출석 인증 시간 변경 #341

merged 1 commit into from
May 15, 2024

Conversation

jihee-dev
Copy link
Member

@jihee-dev jihee-dev commented May 15, 2024 •
edited
Loading

Description

출석 인증 기준 시간 변경

  • 세션 시작 시간이 오후 2시일 때,
- as-is to-be
출석 13:55-14:05 13:50-14:10
지각 14:06-14:30 14:11-16:00
결석 14:31- 16:01-

Screen Shots

Screen Shot Screen Shot

Check List

  • CI/CD 통과여부
  • Develop Mege 시 Squash and Merge 형태로 넣어주세요!
  • 1Approve 이상 Merge
  • Unit Test 작성
  • 연관된 이슈를 PR에 연결해주세요.

@jihee-dev jihee-dev removed the request for review from hoyahozz May 15, 2024 08:37
@github-actions github-actions bot requested a review from hoyahozz May 15, 2024 08:37
@jihee-dev jihee-dev linked an issue May 15, 2024 that may be closed by this pull request
출석 인증 시간 변경 #340
Closed
3 tasks
toastmeister1
toastmeister1 approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@toastmeister1 toastmeister1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 변경된 부분들 확인했습니다~

@jihee-dev jihee-dev merged commit 63e318c into release May 15, 2024
1 check passed
@jihee-dev jihee-dev deleted the feature/update-attendance-time branch May 18, 2024 11:21
jihee-dev added a commit that referenced this pull request Jun 6, 2024
@jihee-dev
Merge branch 'release' of https://github.com/YAPP-admin/attendance-an…
ace2d2a 
…droid into develop

* 'release' of https://github.com/YAPP-admin/attendance-android:
  chore: Version Up (1.4.1 -> 1.4.2) 🔥🔥🔥
  [Feature] 출석 인증 기준 시간 변경 (#341)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toastmeister1 toastmeister1 toastmeister1 approved these changes

@hoyahozz hoyahozz Awaiting requested review from hoyahozz

Assignees

@jihee-dev jihee-dev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

출석 인증 시간 변경
2 participants
@jihee-dev @toastmeister1