Add visual effects for various song phrases #936
+12,755
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefab Y values and render sort order settings also changed, this is needed to deal with solo effect covering indicator strips, bleeding over frets, and masking the bottom of notes on the highway.
This updates TrackPlayer and TrackMaterial to remove everything related to solo shader effects. Solo effect stuff also removed from Track shader graph.
… to use "rails" instead of trim glow.
Solos now have a start and end object pasted onto either end so that the angle of the ends of the rail don't get stretched a variable amount depending on the length of the solo.
Add new shader graph for solo object to correct texture warping with object scale. Update solo track texture to reduce intensity of track glow. Change texture import settings for SoloTrack and SoloTransition to make them single channel alpha masks.
This change should make dealing with unisons during solos easier since the color of the rail and glow can now be controlled separately. Solo object transition effect can now be disabled.
…rmine if there was a successful unison.
Also includes a bad hack to award bonus SP.
… and a unison bonus award only good for testing.
…with effect pool elements not being reactivated.
…engine's solo list. Removes dependency on engine changes for solo and drum fill visual effects.
Track Effect slicer can now slightly adjust timing of visual effects to turn overlapping transitions into adjacency instead. At note speed 5, any gap less than 200ms will trigger this adjustment.
Remove dependency on EngineManager for visual effects. Remove now unnecessary stuff from TrackPlayer.
Added new EngineContainer class so engines don't have to be changed to store their own ID. Removed hacky unison bonus awarding through input system.
…Phrases from TrackEffect.cs. Adjust intensity of solo phrase track glow to better match unison phrases. Remove leftover junk from previous iterations of track effects.
… Adjust solo and unison color/transparency.
Remove rail graphic for drum fill and unison sections. Handle track effect material selected in Unity editor being null gracefully. (so that enabling/disabling a part of the effect can be done only in Unity) Add trim objects to track effect prefab so trim effects can be used. Add preliminary trim glow effect texture. Add trim effect materials for unison and drum fill effects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds visual effects for solo, unison, and drum fill phrases.
Depends on YARG.Core PR #229 for generating unison phrases, but that could be moved into YARG if desired.
Solo effect:
Unison effect:
Drum fill effect:
Solo and unison combo:
