Inhibit drum SP activation gems during active SP #940
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the player has more than half a bar of SP during a drum fill phrase, the activation gem will be generated even if SP is active.
This is because FourLaneDrumsNoteElement checks Player.Engine.CanStarPowerActivate to determine whether notes with the IsStarPowerActivator flag set should have their gem colored with the activation color or the normal color. CanStarPowerActivate does not consider SP activation status, so the gem ends up being purple when it shouldn't be.
This PR conditions the use of the activation color on SP not currently being active when the activator gem is spawned.