#2 Authentication

[orenyk]

Implements #2, allowing for both CAS and email/password authentication. Refer to the issue for commentary; this PR includes significant changes including guest user functionality, integration tests, and more!

Issues Resolved (please check all during review):

• Non-CAS authentication #2
• Install dotenv and figure out relevant environment variables #694
• Remove spin-js-rails (use font-awesome) #777
• Add link to Rails Admin for superusers #965
• Set up access control to Rails Admin #973
• Use secrets.yml for secret stuff #1018

[orenyk]

I don't understand these freaking build failures, they just show up intermittently :-(

[orenyk]

Ok, updated app setup script to account for passwords and also cleaned up seed script. Review when ready :-)

[orenyk]

So frustrating... you can get the tests to apss by just restarting the builds (sometimes). I wish I knew why those two tests were failing.

[squidgetx]

Everything looks good to me that I haven't already commented on I've also managed to cleanly spoof the guest user so we don't need to actually keep the record in the database.

[orenyk]

Awesome! Did you get a chance to look at the app setup script update? I'll look over your changes and we can hopefully get this merged in tonight :-)

[squidgetx]

Yea the app setup script changes are perfect

[orenyk]

Also, did you get a chance to make sure all of the user actions (creation, editing, etc) work as expected under both authentication models, particularly creating a new user from a valid CAS login? That was one of the trickier things I ran into and I want to make sure that nothing's broken (although I tried to write integration tests for them). Thanks!

[squidgetx]

• editing someone's email (nonCAS) will successfully change the email itself but not the username
• password field doesn't exist in CAS mode but the setup script tries to do it anyway (Looks like I didn't go over the setup script as thoroughly as I thought; I fixed this in the latest commit)

[orenyk]

Good catches. I believe that in non-CAS mode Devise is using email as the login parameter, not username, but we should keep them up to date regardless. The password parameter does exist in CAS mode (since our database is the same); that said, I'm not sure if there's any harm in defaulting to nil. Frankly, the app isn't designed to switch between the two authentication systems so I guess it doesn't matter. I'm fixing the first issue you mentioned, thanks!

[orenyk]

Ok, fix pushed (and hiding username on user#show when not using CAS). I think that's it :-)

[squidgetx]

👍

[orenyk]

There are those freaking build failures again... any ideas?

EDIT I don't understand why re-running the build fixes it. So infuriating.

[orenyk]

ok, merging!

[squidgetx]

:D

I have no idea why they were failing, I tried messing with the tests a little bit to see and they accidentally got included in git. Didn't really learn anything valuable though