feat: output numbers with decimal points

Yamato-Security · Mar 1, 2024 · 6ffd0d4 · 6ffd0d4
1 parent d19d935
commit 6ffd0d4
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 10 deletions.
diff --git a/src/takajopkg/listUndetectedEvtxFiles.nim b/src/takajopkg/listUndetectedEvtxFiles.nim
@@ -31,8 +31,9 @@ proc listUndetectedEvtxFiles(columnName: system.string = "EvtxFile", evtxDir: st
             inc numberOfEvtxFiles
         outputStock.add("")
         let undetectedPercentage = (checkResult.len() / fileLists.len()) * 100
+        let numberOfEvtxFilesStr = intToStr(numberOfEvtxFiles).insertSep(',')
         echo fmt"{ undetectedPercentage :.4}% of the evtx files did not have any detections."
-        echo fmt"Number of evtx files not detected: {numberOfEvtxFiles}"
+        echo fmt"Number of evtx files not detected: {numberOfEvtxFilesStr}"
         echo ""
     if output != "":
         let f = open(output, fmWrite)

diff --git a/src/takajopkg/listUnusedRules.nim b/src/takajopkg/listUnusedRules.nim
@@ -28,8 +28,9 @@ proc listUnusedRules(columnName: string = "RuleFile", output: string = "", quiet
             inc numberOfUnusedRules
         let undetectedPercentage = (checkResult.len() / fileLists.len()) * 100
         outputStock.add("")
+        let numberOfUnusedRulesStr = intToStr(numberOfUnusedRules).insertSep(',')
         echo fmt"{ undetectedPercentage :.4}% of the yml rules were not used."
-        echo fmt"Number of unused rule files: {numberOfUnusedRules}"
+        echo fmt"Number of unused rule files: {numberOfUnusedRulesStr}"
         echo ""
     if output != "":
         let f = open(output, fmWrite)

diff --git a/src/takajopkg/timelineLogon.nim b/src/takajopkg/timelineLogon.nim
@@ -226,12 +226,12 @@ proc timelineLogon(calculateElapsedTime: bool = true, output: string, outputLogo
                     tableOfResults[]["AdminLogon"] = "Yes"
 
     echo "Found logon events:"
-    echo "EID 4624 (Successful Logon): ", EID_4624_count
-    echo "EID 4625 (Failed Logon): ", EID_4625_count
-    echo "EID 4634 (Logoff): ", EID_4634_count
-    echo "EID 4647 (User Initiated Logoff): ", EID_4647_count
-    echo "EID 4648 (Explicit Logon): ", EID_4648_count
-    echo "EID 4672 (Admin Logon): ", EID_4672_count
+    echo "EID 4624 (Successful Logon): ", intToStr(EID_4624_count).insertSep(',')
+    echo "EID 4625 (Failed Logon): ", intToStr(EID_4625_count).insertSep(',')
+    echo "EID 4634 (Logoff): ", intToStr(EID_4634_count).insertSep(',')
+    echo "EID 4647 (User Initiated Logoff): ", intToStr(EID_4647_count).insertSep(',')
+    echo "EID 4648 (Explicit Logon): ", intToStr(EID_4648_count).insertSep(',')
+    echo "EID 4672 (Admin Logon): ", intToStr(EID_4672_count).insertSep(',')
     echo ""
 
     # Save results

diff --git a/src/takajopkg/timelineSuspiciousProcesses.nim b/src/takajopkg/timelineSuspiciousProcesses.nim
@@ -224,7 +224,7 @@ proc timelineSuspiciousProcesses(level: string = "high", output: string = "", qu
         echo ""
         return
 
-    echo "Suspicious processes in Security 4688 process creation events: " & $suspicousProcessCount_Sec_4688
-    echo "Suspicious processes in Sysmon 1 process creation events: " & $suspicousProcessCount_Sysmon_1
+    echo "Suspicious processes in Security 4688 process creation events: " & intToStr(suspicousProcessCount_Sec_4688).insertSep(',')
+    echo "Suspicious processes in Sysmon 1 process creation events: " & intToStr(suspicousProcessCount_Sysmon_1).insertSep(',')
     echo ""
     outputElapsedTime(startTime)