Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Adding support for TF structure for arbitrary many watermarks #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aubrey-stripe
Copy link

@aubrey-stripe aubrey-stripe commented Apr 5, 2018

Motivation: Allow for arbitrarily many watermarks in a chart.

Tested that this allows for a structure like the following in a dashboard chart

axis_right {
  high_watermark = 0.99
  high_watermark_label = "bad"
  low_watermark = 0.01
  low_watermark_label = "good-ish"
  watermarks {
    label = "bad"
    value = 0.99
  }
  watermarks {
    label = "good-ish"
    value = 0.01
  }
}
~ module.dashboards.signalform_time_chart.chart_133767_0
    axis_right.#:                                       "0" => "1"
    axis_right.509551474.high_watermark:                "" => "0.99"
    axis_right.509551474.high_watermark_label:          "" => "bad"
    axis_right.509551474.low_watermark:                 "" => "0.01"
    axis_right.509551474.low_watermark_label:           "" => "good-ish"
    axis_right.509551474.watermarks.#:                  "0" => "2"
    axis_right.509551474.watermarks.2403508488.label:   "" => "bad"
    axis_right.509551474.watermarks.2403508488.value:   "" => "0.99"
    axis_right.509551474.watermarks.3497209033.label:   "" => "good-ish"
    axis_right.509551474.watermarks.3497209033.value:   "" => "0.01"

@aubrey-stripe
Copy link
Author

Oh no, I'm so sorry I meant to open this PR to our stripe fork to discuss internally. I'm going to edit this to a WIP.

@aubrey-stripe aubrey-stripe changed the title Adding support for TF structure for arbitrary many watermarks WIP Adding support for TF structure for arbitrary many watermarks Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant