Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ci & release workflow #23

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Conversation

luckasRanarison
Copy link
Contributor

@luckasRanarison luckasRanarison commented Jan 28, 2024

Added CI, build, release and publish workflows. Note that the release and publish worflows haven't been tested yet. You'll need to add the environment secrets.
Also linting is currently failing, I'll make a PR to fix it first, if you'd like to add linting.

@luckasRanarison
Copy link
Contributor Author

luckasRanarison commented Jan 28, 2024

Also I've tried building on my branch and the released build are somehow bigger than yours 7-8mb vs 1-2mb for you. Did you apply some optimizations?
Here's one of the artifact I've build using this workflow: https://github.com/luckasRanarison/cmd-wrapped/actions/runs/7683753461/artifacts/1200330615.

@YiNNx
Copy link
Owner

YiNNx commented Jan 28, 2024

the released build are somehow bigger than yours 7-8mb vs 1-2mb for you. Did you apply some optimizations?

I find our binary file sizes are just similar, and the 1-2mb is just the package size after compression? I build the releases using https://github.com/joseluisq/rust-linux-darwin-builder, and apply the musl option for Linux builds

@luckasRanarison
Copy link
Contributor Author

luckasRanarison commented Jan 28, 2024

I find our binary file sizes are just similar, and the 1-2mb is just the package size after compression?

Oh, I didn't realize it was compressed xD. I'll try to add a compression step.

@luckasRanarison luckasRanarison marked this pull request as ready for review January 28, 2024 08:10
@luckasRanarison
Copy link
Contributor Author

luckasRanarison commented Jan 28, 2024

It should theorically work (I hope), you just need to setup the GITHUB_TOKEN, and CRATES_IO_TOKEN for publishing

@YiNNx
Copy link
Owner

YiNNx commented Feb 5, 2024

Apologies for the delayed response (have been struggling with some personal matters :(
Now it's time to test the workflow, hoping everything will function as expected 👀

@YiNNx YiNNx merged commit 31facda into YiNNx:master Feb 5, 2024
@luckasRanarison
Copy link
Contributor Author

luckasRanarison commented Feb 5, 2024

Apologies for the delayed response (have been struggling with some personal matters :(

No problem :)

Now it's time to test the workflow, hoping everything will function as expected 👀

Waiting for the next release...

By the way, do you think we could use crossterm? It'd be easy to implement advanced terminal features using crossterm and implement #12.

@YiNNx
Copy link
Owner

YiNNx commented Feb 5, 2024

By the way, do you think we could use crossterm? It'd be easy to implement advanced terminal features using crossterm and implement #12.

It seems like a good try!

@YiNNx
Copy link
Owner

YiNNx commented Feb 5, 2024

I removed the armv7 package which is rarely required, and fixed the underline typo for x86_64-apple-darwin package which caused a package generating error. I also changed the auto-release to be marked as draft so that I can edit the Release Note manually.

Now all look good to me 🥳 Thanks!

image

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants