Remove exclusion for the PrefixAllGlobals sniff after changes to `b…

…ootstrap.php`
Yoast · Sep 28, 2023 · 4c62e97 · 4c62e97
1 parent 4111485
commit 4c62e97
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/.phpcs.xml.dist b/.phpcs.xml.dist
@@ -108,11 +108,6 @@
 
 	<!-- TEST CODE -->
 
-	<!-- Valid usage: For testing purposes, some non-prefixed globals are being created, which is fine. -->
-	<rule ref="WordPress.NamingConventions.PrefixAllGlobals">
-		<exclude-pattern>/tests/*/bootstrap\.php$</exclude-pattern>
-	</rule>
-
 	<!-- Valid usage: For testing purposes, some non-prefixed global constants are being created, which is fine. -->
 	<rule ref="WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedConstantFound">
 		<exclude-pattern>/tests/*\.php$</exclude-pattern>

diff --git a/tests/wp/bootstrap.php b/tests/wp/bootstrap.php
@@ -20,10 +20,8 @@
  */
 require_once dirname( __DIR__, 2 ) . '/vendor/yoast/wp-test-utils/src/WPIntegration/bootstrap-functions.php';
 
-$_wp_tests_dir = WPIntegration\get_path_to_wp_test_dir();
-
 // Get access to tests_add_filter() function.
-require_once $_wp_tests_dir . 'includes/functions.php';
+require_once WPIntegration\get_path_to_wp_test_dir() . 'includes/functions.php';
 
 tests_add_filter(
 	'muplugins_loaded',