Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer/Tests: update test dependencies #329

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Oct 4, 2023

Context

  • Updated test dependencies

Summary

This PR can be summarized in the following changelog entry:

  • Updated test dependencies

Relevant technical choices:

This updates the minimum version of the WP Test Utils dependency.

This also allows us to remove the work-around which was in place for Mockery not handling dynamic properties on mocked objects. This was fixed in Mockery 1.6.0, which will be used when running the tests against PHP 8.2+.

Note: PHPUnit Polyfills 1.1.0 includes a new polyfill for the assertObject[Not]HasProperty() methods. The assertions which these new assertions replace are not used in this test suite, so no test changes are needed.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • N/A If the build passes, we're good.

This updates the minimum version of the WP Test Utils dependency.

This also allows us to remove the work-around which was in place for Mockery not handling dynamic properties on mocked objects.
This was fixed in Mockery 1.6.0, which will be used when running the tests against PHP 8.2+.

Note: PHPUnit Polyfills 1.1.0 includes a new polyfill for the `assertObject[Not]HasProperty()` methods.
The assertions which these new assertions replace are not used in this test suite, so no test changes are needed.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6408351560

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 48.608%

Totals Coverage Status
Change from base Build 6408306830: 0.0%
Covered Lines: 1100
Relevant Lines: 2263

💛 - Coveralls

@jrfnl jrfnl merged commit 129479f into trunk Oct 4, 2023
21 checks passed
@jrfnl jrfnl deleted the JRF/update-test-dependencies branch October 4, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants