Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: use PSR-4 #334

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Tests: use PSR-4 #334

merged 2 commits into from
Nov 20, 2023

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Nov 20, 2023

Context

  • Improve dev experience

Summary

This PR can be summarized in the following changelog entry:

  • Tests: use PSR-4

Relevant technical choices:

Tests: make sure all files are namespaced

... including the test bootstrap.

Includes ensuring that all calls to global functions and global constants are now fully qualified.

Tests: use PSR-4

  • Ensure subdirectory names use "ProperCase".
  • Ensure all test class file names match the name of the test class.
  • Change the Composer autoload-dev directive to use PSR-4 autoloading.
  • Update the phpunit.xml.dist file to match.
  • Update the .phpcs.xml.dist file to match.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • N/A If the tests pass, we're good.

... including the test bootstrap.

Includes ensuring that all calls to global functions and global constants are now fully qualified.
* Ensure subdirectory names use "ProperCase".
* Ensure all test class file names match the name of the test class.
* Change the Composer `autoload-dev` directive to use PSR-4 autoloading.
* Update the `phpunit.xml.dist` file to match.
* Update the `.phpcs.xml.dist` file to match.
@jrfnl jrfnl added this to the 4.6 milestone Nov 20, 2023
@jrfnl jrfnl changed the title Jrf/tests use psr4 Tests: use PSR-4 Nov 20, 2023
@jrfnl jrfnl merged commit c010070 into trunk Nov 20, 2023
21 checks passed
@jrfnl jrfnl deleted the JRF/tests-use-psr4 branch November 20, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant