Tests: make dataproviders static

As of PHPUnit 10, data providers are (again) expected to be `static` methods. This updates the test suite to respect that.
Yoast · Sep 26, 2023 · 5df8d9d · 5df8d9d
1 parent 54900d1
commit 5df8d9d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/tests/MessageDismisserTest.php b/tests/MessageDismisserTest.php
@@ -57,7 +57,7 @@ public function testIsDismissibleWithVersions( $savedTime, $currentTime, $expect
 	 *
 	 * @return array<string, array<int|bool>>
 	 */
-	public function versionNumbersProvider() {
+	public static function versionNumbersProvider() {
 		return array(
 			'-2weeks' => array( strtotime( '-2weeks' ), time(), true ),
 			'-4weeks' => array( strtotime( '-4weeks' ), time(), true ),

diff --git a/tests/VersionRequirementTest.php b/tests/VersionRequirementTest.php
@@ -172,7 +172,7 @@ public function testFromCompareString( $expectation, $component, $compareString
 	 *
 	 * @return array<string, array<string|array<string>>>
 	 */
-	public function dataFromCompareString() {
+	public static function dataFromCompareString() {
 		return array(
 			'php > 5.5'  => array( array( 'php', '5.5', '>' ), 'php', '>5.5' ),
 			'php >= 5.5' => array( array( 'php', '5.5', '>=' ), 'php', '>=5.5' ),

diff --git a/tests/WPMessageDismissListenerTest.php b/tests/WPMessageDismissListenerTest.php
@@ -53,7 +53,7 @@ public function testDismiss( $action, $nonce, $verifyNonceTimes, $isCorrectNonce
 	 *
 	 * @return array<string, array<string, mixed>>
 	 */
-	public function listenProvider() {
+	public static function listenProvider() {
 		return array(
 			'correct action and nonce' => array(
 				'action'                => Whip_WPMessageDismissListener::ACTION_NAME,