Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA/Docs: minor fixes #160

Merged
merged 2 commits into from
Dec 22, 2023
Merged

QA/Docs: minor fixes #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4c055d
Docs: improve types
jrfnl Dec 22, 2023
b36948a
RequirementsCheckerTest: pass the correct type
jrfnl Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class Configuration {
/**
* Configuration constructor.
*
* @param array<string> $configuration The configuration to use.
* @param array<string, string> $configuration The configuration to use.
*
* @throws InvalidType When the $configuration parameter is not of the expected type.
*/
Expand Down
4 changes: 2 additions & 2 deletions src/RequirementsChecker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ class RequirementsChecker {
/**
* RequirementsChecker constructor.
*
* @param array<Requirement> $configuration The configuration to check.
* @param string $textdomain The text domain to use for translations.
* @param array<string, string> $configuration The configuration to check.
* @param string $textdomain The text domain to use for translations.
*
* @throws InvalidType When the $configuration parameter is not of the expected type.
*/
Expand Down
8 changes: 4 additions & 4 deletions tests/Unit/RequirementsCheckerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public function testIfRequirementExists() {
* @return void
*/
public function testCheckIfPHPRequirementIsNotFulfilled() {
$checker = new RequirementsChecker( array( 'php' => 4 ) );
$checker = new RequirementsChecker( array( 'php' => '4' ) );

$checker->addRequirement( new VersionRequirement( 'php', '5.6' ) );
$checker->check();
Expand Down Expand Up @@ -189,7 +189,7 @@ public function testCheckIfRequirementIsFulfilled() {
* @return void
*/
public function testCheckIfRequirementIsNotFulfilled() {
$checker = new RequirementsChecker( array( 'mysql' => 4 ) );
$checker = new RequirementsChecker( array( 'mysql' => '4' ) );

$checker->addRequirement( new VersionRequirement( 'mysql', '5.6' ) );
$checker->check();
Expand All @@ -215,7 +215,7 @@ public function testCheckIfRequirementIsNotFulfilled() {
* @return void
*/
public function testCheckIfRequirementIsFulfilledWithSpecificComparison() {
$checker = new RequirementsChecker( array( 'php' => 4 ) );
$checker = new RequirementsChecker( array( 'php' => '4' ) );

$checker->addRequirement( new VersionRequirement( 'php', '5.2', '<' ) );
$checker->check();
Expand All @@ -233,7 +233,7 @@ public function testCheckIfRequirementIsFulfilledWithSpecificComparison() {
* @return void
*/
public function testCheckIfRequirementIsNotFulfilledWithSpecificComparison() {
$checker = new RequirementsChecker( array( 'php' => 4 ) );
$checker = new RequirementsChecker( array( 'php' => '4' ) );

$checker->addRequirement( new VersionRequirement( 'php', '5.2', '>=' ) );
$checker->check();
Expand Down