-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build XML Sitemaps with indexables #17869
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itemaps-indexables
…dv/xml-sitemaps-indexables
This removes the direct dependency from the function and is one step closer to using dependency injection once we move this class to src
This fixes a bug where a new page was shown on the sitemap index that did not exist when the number of posts matches the number of links per page (or a multiple thereof).
diedexx
added
the
changelog: enhancement
Needs to be included in the 'Enhancements' category in the changelog
label
Dec 20, 2021
4 tasks
…axonomy sitemap provider
herregroen
approved these changes
Dec 30, 2021
replaced by feature/indexable-sitemaps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #17757
Replaces #17580
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Prep
wp yoast index
WP-CLI command.Sitemap contents
Pagination
add_filter( 'Yoast\WP\SEO\xml_sitemaps_entries_per_sitemap', function($entries){return 5;});
Last modified dates
Excluding objects from the sitemap
Images
Test instructions for QA when the code is in the RC
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
Documentation
Quality assurance