-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing padding on .container. #55
Conversation
Sorry for the late response, I'm finally starting to get over this flu so I'm back! |
@Leftium Any reason why we don't put padding on the I wrote out below after investigating this some more, but will be update the padding here shortly on these containers. This is my theory as to why it was like this previouslyReasoningBefore your change:The After your change:The IntentHow I see this being intentional is because when the screen width is less than the smallest breakpoint, we would want padding on the |
@Yohn I think your theory is correct! I forgot the padding would still apply if the viewport width is less than width of the smallest breakpoint. (And I think we should revert this PR. Here is the reason I wanted padding: 0 for the smallest breakpoint and non-zero padding for the other breakpoints; perhaps it is a different bug or I need to use Pico CSS differently:
Here At the smallest breakpoint, the gray body background is no longer visible. (But I guess padding is still needed!): |
I edited my previous comment several times as I figured things out in real-time, so make you read the latest version! On a related note, the way Pico CSS adds "mandatory" margin (the body background color gray region in the screenshot above) made it difficult to control how the page is printed. (The printer also wanted to add its own margin.) After I figured out what the issue was, I solved it with this bit of CSS: https://github.com/Leftium/leftium.com/blob/2da29794575ef604bafec8cdf8fe5aa551a5efdf/src/app.scss#L30-L34 |
Here's a suggestion for how to resolve this:
|
…gh space for the arrow, and keep the arrow at the top when theres multi-lines for the sumary text. Reverted back the container padding.
Fixes picocss#654.