Fix undefined type error #4852
Merged
Fix undefined type error #4852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see how this could be related to Tcl 9.0 but the change itself is desirable. Please update the commit message if you can to remove the mention of Tcl. |
Under certain conditions, compilation errors out with
the following message:
"error: ‘uint8_t’ does not name a type"
Explicitly including <cstdint> prevents that situation.
Signed-off-by: Gabriel Somlo <[email protected]>
gsomlo
force-pushed
the
gls-tcl9-json11cpp-cstdint
branch
from
6f1cfec to
fe79a77
Compare
|
On Thu, Jan 16, 2025 at 10:38:54AM -0800, Martin Povišer wrote:
I don't see how this could be related to Tcl 9.0
Might be just a coincidence -- it only happens to me during
mock-building an RPM for fedora when the build environment
has been configured with the latest Tcl 9.0.
but the change itself is desirable. Please update the commit
message if you can to remove the mention of Tcl.
Done. Thanks for the quick feedback!
Best,
--Gabriel
|
povik
changed the title
povik
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly include in libs/json11/json11.cpp, to avoid:
compile errors when building against TCL 9.0
(https://bugzilla.redhat.com/show_bug.cgi?id=2337817)