Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for passing flatten -separator to flatten in synth #4856

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

gadfort
Copy link
Contributor

@gadfort gadfort commented Jan 18, 2025

What are the reasons/motivation for this change?

Closes #4843

Explain how this is achieved.

Since #4839 added this flag to flatten, this change allows for the user to specify this for the synth command.

If applicable, please suggest to reviewers how they can test the change.

scratchpad -set flatten.separator "/"
synth -flatten
write_verilog test.v

@whitequark
Copy link
Member

The scratchpad check should be in the flatten pass, not synth, shouldn't it?

@gadfort
Copy link
Contributor Author

gadfort commented Jan 18, 2025

@whitequark sure, I can move it there (makes more sense there)

@gadfort
Copy link
Contributor Author

gadfort commented Jan 18, 2025

Looks like the failures might be related to the switch from ubuntu22 to ubuntu24 on the github runners

@povik povik merged commit 0c95a76 into YosysHQ:main Jan 20, 2025
25 checks passed
@gadfort gadfort deleted the synth-flatten branch January 20, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support for flatten.separator in synth
3 participants