Update workflow(s) for ubuntu-latest == ubuntu-24.04 #4858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oldest clang on 24.04 appears to be 16.
Use clang-19 as latest
clang-11 through clang-16 fail under 24.04, but clang-10 works, so we can move that up to the oldest supported and drop the extra target for ubuntu-20.04
|
13fdd52 fixes tests for ubuntu, but breaks macos. Minimum fix to get CI passing is just put it behind a |
mmicko
force-pushed
the
update_latest-24.04
branch
from
13fdd52 to
6b44997
Compare
mmicko
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
ubuntu-latest is now 24.04 instead of 22.04 and broke some things:
Explain how this is achieved.
Change clang-14 to clang-10 as oldest supported under ubuntu-latest (somehow clang-10 is now working under latest but clang-11 through clang-16 are not).
Also update newest clang to -19.
apt-get libbz2-dev.
If applicable, please suggest to reviewers how they can test the change.