Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize UI for PIV when not FIPS approved #1659

Merged
merged 1 commit into from
Aug 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/l10n/app_de.arb
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,7 @@
"l_delete_certificate_or_key_desc": "Entfernen Sie das Zertifikat oder den Schlüssel von Ihrem YubiKey",
"l_move_key": "Schlüssel verschieben",
"l_move_key_desc": "Verschieben Sie einen Schlüssel von einem PIV-Slot in einen anderen",
"l_change_defaults": null,
"s_issuer": "Aussteller",
"s_serial": "Serial",
"s_certificate_fingerprint": "Fingerprint",
Expand Down
1 change: 1 addition & 0 deletions lib/l10n/app_en.arb
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,7 @@
"l_delete_certificate_or_key_desc": "Remove the certificate or key from your YubiKey",
"l_move_key": "Move key",
"l_move_key_desc": "Move a key from one PIV slot into another",
"l_change_defaults": "Change default access codes",
"s_issuer": "Issuer",
"s_serial": "Serial",
"s_certificate_fingerprint": "Fingerprint",
Expand Down
1 change: 1 addition & 0 deletions lib/l10n/app_fr.arb
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,7 @@
"l_delete_certificate_or_key_desc": "Supprimer le certificat ou la clé de votre YubiKey",
"l_move_key": "Déplacer la clé",
"l_move_key_desc": "Déplacer une clé d'un emplacement PIV vers un autre",
"l_change_defaults": null,
"s_issuer": "Émetteur",
"s_serial": "Série",
"s_certificate_fingerprint": "Empreinte digitale",
Expand Down
1 change: 1 addition & 0 deletions lib/l10n/app_ja.arb
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,7 @@
"l_delete_certificate_or_key_desc": "YubiKey から証明書または鍵を削除する",
"l_move_key": "キーを移動",
"l_move_key_desc": "あるPIVスロットから別のスロットにキーを移動する",
"l_change_defaults": null,
"s_issuer": "発行者",
"s_serial": "シリアル",
"s_certificate_fingerprint": "フィンガープリント",
Expand Down
1 change: 1 addition & 0 deletions lib/l10n/app_pl.arb
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,7 @@
"l_delete_certificate_or_key_desc": null,
"l_move_key": null,
"l_move_key_desc": null,
"l_change_defaults": null,
"s_issuer": "Wydawca",
"s_serial": "Nr. seryjny",
"s_certificate_fingerprint": "Odcisk palca",
Expand Down
18 changes: 14 additions & 4 deletions lib/piv/views/actions.dart
Original file line number Diff line number Diff line change
Expand Up @@ -312,12 +312,22 @@ class PivActions extends ConsumerWidget {
List<ActionItem> buildSlotActions(
PivState pivState, PivSlot slot, bool fipsUnready, AppLocalizations l10n) {
if (fipsUnready) {
// TODO: Decide on final look and move strings to .arb file.
return [
ActionItem(
icon: const Icon(Symbols.add),
title: 'Provision slot',
subtitle: 'Change from default PIN/PUK/Management key first'),
key: keys.generateAction,
feature: features.slotsGenerate,
icon: const Icon(Symbols.add),
actionStyle: ActionStyle.primary,
title: l10n.s_generate_key,
subtitle: l10n.l_change_defaults,
),
ActionItem(
key: keys.importAction,
feature: features.slotsImport,
icon: const Icon(Symbols.file_download),
title: l10n.l_import_file,
subtitle: l10n.l_change_defaults,
),
];
}
final hasCert = slot.certInfo != null;
Expand Down
Loading