Use iterator in I2C read

Roll `transmit_stop()` into the loop
YuhanLiin · Jan 5, 2025 · 81534e4 · 81534e4
1 parent f8a7e73
commit 81534e4
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/src/i2c.rs b/src/i2c.rs
@@ -406,17 +406,16 @@ impl<USCI: I2cUsci> I2cBus<USCI> {
             return Err::<(), I2CErr>(I2CErr::GotNACK);
         }
 
-        for i in 0..buffer.len() - 1 {
+        let len = buffer.len();
+        for (idx, byte) in buffer.iter_mut().enumerate() {
             while !ifg.ucrxifg0() {
                 ifg = usci.ifg_rd();
             }
-            buffer[i] = usci.ucrxbuf_rd();
-        }
-        usci.transmit_stop();
-        while !ifg.ucrxifg0() {
-            ifg = usci.ifg_rd();
+            *byte = usci.ucrxbuf_rd();
+            if idx == len - 2 {
+                usci.transmit_stop();
+            }
         }
-        buffer[buffer.len() - 1] = usci.ucrxbuf_rd();
 
         while usci.uctxstp_rd() {
             asm::nop();