🧪 Add some failing unit tests and improve the existing ones

api/src/main/java/be/darkkraft/transferproxy/api/profile/ClientInformationImpl.java

@@ -24,8 +24,7 @@
 
 package be.darkkraft.transferproxy.api.profile;
 
-record ClientInformationImpl(String locale, byte viewDistance, ChatVisibility chatVisibility, boolean chatColors,
-                                    byte displayedSkinParts, MainHand mainHand, boolean enableTextFiltering,
-                                    boolean allowServerListing) implements ClientInformation {
+record ClientInformationImpl(String locale, byte viewDistance, ChatVisibility chatVisibility, boolean chatColors, byte displayedSkinParts,
+                             MainHand mainHand, boolean enableTextFiltering, boolean allowServerListing) implements ClientInformation {
 
 }

api/src/test/java/be/darkkraft/transferproxy/api/profile/ChatVisibilityTest.java

@@ -32,15 +32,15 @@ class ChatVisibilityTest {
 
     @Test
     void testIdEqualsOrdinal() {
-        for (final ChatVisibility result : ChatVisibility.values()) {
-            assertEquals(result.ordinal(), result.getId());
+        for (final ChatVisibility visibility : ChatVisibility.values()) {
+            assertEquals(visibility.ordinal(), visibility.getId());
         }
     }
 
     @Test
     void testEqualityWithFromId() {
-        for (final ChatVisibility result : ChatVisibility.values()) {
-            assertSame(ChatVisibility.fromId(result.getId()), result);
+        for (final ChatVisibility visibility : ChatVisibility.values()) {
+            assertSame(visibility, ChatVisibility.fromId(visibility.getId()));
         }
     }
 

api/src/test/java/be/darkkraft/transferproxy/api/profile/MainHandTest.java

@@ -32,15 +32,15 @@ class MainHandTest {
 
     @Test
     void testIdEqualsOrdinal() {
-        for (final MainHand result : MainHand.values()) {
-            assertEquals(result.ordinal(), result.getId());
+        for (final MainHand hand : MainHand.values()) {
+            assertEquals(hand.ordinal(), hand.getId());
         }
     }
 
     @Test
     void testEqualityWithFromId() {
-        for (final MainHand result : MainHand.values()) {
-            assertSame(MainHand.fromId(result.getId()), result);
+        for (final MainHand hand : MainHand.values()) {
+            assertSame(hand, MainHand.fromId(hand.getId()));
         }
     }
 

api/src/test/java/be/darkkraft/transferproxy/api/resourcepack/ResourcePackResultTest.java

@@ -40,7 +40,7 @@ void testIdEqualsOrdinal() {
     @Test
     void testEqualityWithFromId() {
         for (final ResourcePackResult result : ResourcePackResult.values()) {
-            assertSame(ResourcePackResult.fromId(result.getId()), result);
+            assertSame(result, ResourcePackResult.fromId(result.getId()));
         }
     }
 

core/src/main/java/be/darkkraft/transferproxy/network/packet/config/serverbound/ClientInformationPacket.java

@@ -40,6 +40,17 @@ public record ClientInformationPacket(String locale, byte viewDistance, ChatVisi
                                       byte displayedSkinParts, MainHand mainHand, boolean enableTextFiltering,
                                       boolean allowServerListing) implements ServerboundPacket, ClientInformation {
 
+    public ClientInformationPacket(final @NotNull ClientInformation information) {
+        this(information.locale(),
+                information.viewDistance(),
+                information.chatVisibility(),
+                information.chatColors(),
+                information.displayedSkinParts(),
+                information.mainHand(),
+                information.enableTextFiltering(),
+                information.allowServerListing());
+    }
+
     public ClientInformationPacket(final @NotNull ByteBuf buf) {
         this(readString(buf, 16),
                 buf.readByte(),

core/src/main/java/be/darkkraft/transferproxy/network/packet/provider/PacketProvider.java

@@ -47,7 +47,8 @@ public interface PacketProvider {
     PacketProvider[] HANDSHAKE = {HandshakePacket::new};
     PacketProvider[] STATUS = {StatusRequestPacket::new, PingPongPacket::new};
     PacketProvider[] LOGIN = {LoginStartPacket::new, null, null, LoginAcknowledgedPacket::new, LoginCookieResponsePacket::new};
-    PacketProvider[] CONFIG = {ClientInformationPacket::new, ConfigCookieResponsePacket::new, PluginMessagePacket::from, FinishConfigurationPacket::new, KeepAlivePacket::new, null, ResourcePackResponsePacket::new};
+    PacketProvider[] CONFIG =
+            {ClientInformationPacket::new, ConfigCookieResponsePacket::new, PluginMessagePacket::from, FinishConfigurationPacket::new, KeepAlivePacket::new, null, ResourcePackResponsePacket::new};
 
     Packet provide(final @NotNull ByteBuf buf);
 
@@ -71,7 +72,7 @@ static Packet buildPacket(final @NotNull ConnectionState state, final @NotNull B
         return packet;
     }
 
-    private static PacketProvider[] getProviders(final @NotNull ConnectionState state) {
+    static PacketProvider[] getProviders(final @NotNull ConnectionState state) {
         return switch (state) {
             case HANDSHAKE -> HANDSHAKE;
             case STATUS -> STATUS;

core/src/test/java/be/darkkraft/transferproxy/network/packet/PacketTestBase.java

@@ -0,0 +1,57 @@
+/*
+ * MIT License
+ *
+ * Copyright (c) 2024 Darkkraft
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+package be.darkkraft.transferproxy.network.packet;
+
+import be.darkkraft.transferproxy.api.network.packet.Packet;
+import io.netty.buffer.ByteBuf;
+import io.netty.buffer.Unpooled;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+
+import java.util.function.Function;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+public class PacketTestBase {
+
+    private ByteBuf buf;
+
+    @BeforeEach
+    void setUp() {
+        this.buf = Unpooled.buffer();
+    }
+
+    protected <T extends Packet> void test(final T packet, final Function<ByteBuf, T> builder) {
+        packet.write(this.buf);
+        assertEquals(packet, builder.apply(this.buf));
+        assertEquals(0, this.buf.readableBytes());
+    }
+
+    @AfterEach
+    void tearDown() {
+        this.buf.release();
+    }
+
+}

core/src/test/java/be/darkkraft/transferproxy/network/packet/config/FinishConfigurationPacketTest.java

@@ -0,0 +1,37 @@
+/*
+ * MIT License
+ *
+ * Copyright (c) 2024 Darkkraft
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+package be.darkkraft.transferproxy.network.packet.config;
+
+import be.darkkraft.transferproxy.network.packet.PacketTestBase;
+import org.junit.jupiter.api.Test;
+
+class FinishConfigurationPacketTest extends PacketTestBase {
+
+    @Test
+    void testWriteReadConsistency() {
+        this.test(new FinishConfigurationPacket(), FinishConfigurationPacket::new);
+    }
+
+}

core/src/test/java/be/darkkraft/transferproxy/network/packet/config/KeepAlivePacketTest.java

@@ -0,0 +1,39 @@
+/*
+ * MIT License
+ *
+ * Copyright (c) 2024 Darkkraft
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+package be.darkkraft.transferproxy.network.packet.config;
+
+import be.darkkraft.transferproxy.network.packet.PacketTestBase;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
+
+class KeepAlivePacketTest extends PacketTestBase {
+
+    @ParameterizedTest
+    @ValueSource(longs = {0L, 5L, Long.MIN_VALUE, Long.MAX_VALUE})
+    void testWriteReadConsistency(final long payload) {
+        this.test(new KeepAlivePacket(payload), KeepAlivePacket::new);
+    }
+
+}

core/src/test/java/be/darkkraft/transferproxy/network/packet/config/PluginMessagePacketTest.java

@@ -0,0 +1,39 @@
+/*
+ * MIT License
+ *
+ * Copyright (c) 2024 Darkkraft
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+package be.darkkraft.transferproxy.network.packet.config;
+
+import be.darkkraft.transferproxy.network.packet.PacketTestBase;
+import be.darkkraft.transferproxy.network.packet.config.payload.BrandPayload;
+import org.junit.jupiter.api.Test;
+
+class PluginMessagePacketTest extends PacketTestBase {
+
+    @Test
+    void testWriteReadConsistency() {
+        this.test(new PluginMessagePacket("minecraft:brand", new BrandPayload("vanilla")), PluginMessagePacket::from);
+        this.test(new PluginMessagePacket("minecraft:unknown", null), PluginMessagePacket::from);
+    }
+
+}

core/src/test/java/be/darkkraft/transferproxy/network/packet/config/clientbound/AddResourcePackPacketTest.java

@@ -0,0 +1,64 @@
+/*
+ * MIT License
+ *
+ * Copyright (c) 2024 Darkkraft
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+package be.darkkraft.transferproxy.network.packet.config.clientbound;
+
+import be.darkkraft.transferproxy.network.packet.PacketTestBase;
+import be.darkkraft.transferproxy.util.test.TestGenerationUtil;
+import io.netty.handler.codec.DecoderException;
+import org.junit.jupiter.api.Test;
+
+import java.util.UUID;
+
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+class AddResourcePackPacketTest extends PacketTestBase {
+
+    @Test
+    void testWriteReadConsistency() {
+        this.test(new AddResourcePackPacket(UUID.randomUUID(), "url", "hash", true, TestGenerationUtil.generateComplexComponent()),
+                AddResourcePackPacket::new);
+    }
+
+    @Test
+    void testWriteTooLongUrl() {
+        assertThrows(DecoderException.class,
+                () -> this.test(new AddResourcePackPacket(UUID.randomUUID(),
+                        "a".repeat(Short.MAX_VALUE + 1),
+                        "hash",
+                        true,
+                        TestGenerationUtil.generateComplexComponent()), AddResourcePackPacket::new));
+    }
+
+    @Test
+    void testWriteTooLongHash() {
+        assertThrows(DecoderException.class,
+                () -> this.test(new AddResourcePackPacket(UUID.randomUUID(),
+                        "url",
+                        "a".repeat(41),
+                        true,
+                        TestGenerationUtil.generateComplexComponent()), AddResourcePackPacket::new));
+    }
+
+}

core/src/test/java/be/darkkraft/transferproxy/network/packet/config/clientbound/ConfigCookieRequestPacketTest.java

@@ -0,0 +1,37 @@
+/*
+ * MIT License
+ *
+ * Copyright (c) 2024 Darkkraft
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+package be.darkkraft.transferproxy.network.packet.config.clientbound;
+
+import be.darkkraft.transferproxy.network.packet.PacketTestBase;
+import org.junit.jupiter.api.Test;
+
+class ConfigCookieRequestPacketTest extends PacketTestBase {
+
+    @Test
+    void testWriteReadConsistency() {
+        this.test(new ConfigCookieRequestPacket("minecraft:cookie_key"), ConfigCookieRequestPacket::new);
+    }
+
+}