-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translations #40
Merged
Add translations #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add more localization - Add stub for the C++ part of the translation
- Using `std::string` instead of `std::string_view`.
15 tasks
- Add `generate_changelog.py`. - Improve typing and documentation.
- Using a vector of elements instead of passing through va_args. - Add more localization strings.
- `format` now checks for invalid values of index. - Added tests for `format`.
813ethan
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-C++
Code - Pull requests that update C++ code.
C-CMake
Code - Pull requests that update CMake files.
C-Python
Code - Pull requests that update Python code
T-Feature
Type - New feature or request
T-Vulnerability
Type - A vulnerability that can be exploited, for example, dangerous code
W-Incompatible
Warning - Breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds translations in various languages to Steppable.
This PR addresses #41.
Warning
This PR changes things in an incompatible manner.
std::string
to operate instead ofstring_view
to save casts.vFormat
is removed. It is replaced byformat::format
.Changelog:
root
.steppable::__internals::utils::getHomeDirectory()
std::string
instead ofstd::string_view
.generate_changelog.py
.format.cpp
.format
now checks for invalid values of index.format
.