Support blmo type and passed test for Cube polytope #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
adding pre_computed_set for DICG
supporting pre_computed_set in DICG
add split_pre_computed_set! function
adding pre_computed_set arg for DICG
dhendryc
requested changes
Jul 30, 2024
remove if statement
dhendryc
requested changes
Sep 25, 2024
src/blmo_interface.jl
Outdated
There was a problem hiding this comment.
You have to add the other DICG functions as well. They can have some default behaviour, i.e. throw an error that this is not implemented yet.
src/interface.jl
Outdated
Comment on lines
171
to
177
| if use_DICG_warm_start | ||
| # For DICG, we use PrecomputedSet instead of ActiveSet to store information. | ||
| pre_computed_set = [v] | ||
| else | ||
| pre_computed_set = nothing | ||
| end | ||
|
|
There was a problem hiding this comment.
You can write this in a single line as
pre_computed_set = use_DICG_warm_start ? [v] : nothing
test/simple_test_ODWB.jl
Outdated
There was a problem hiding this comment.
Take a look at the cleaned up example here
https://github.com/ZIB-IOL/Boscia.jl/blob/main/examples/optimal_experiment_design.jl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified code in frank_wolfe_variants.jl, Boscia.jl, node.jl, polytope_blmos.jl, time_tracking_lmo.jl, managed_blmo.jl.
All changed or added code is wrapped by
#=========================#
......
#=========================#