Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Alternating Linear Minimization #407

Merged
merged 21 commits into from
Aug 7, 2023
Merged

Conversation

JannisHal
Copy link
Collaborator

Implemented Alternating Linear Minimization framework with Block Coordinate FW corresponding tests and examples.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 95.48% and project coverage change: -0.51% ⚠️

Comparison is base (4468c8f) 87.67% compared to head (9df69b2) 87.17%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
- Coverage   87.67%   87.17%   -0.51%     
==========================================
  Files          18       20       +2     
  Lines        2239     2370     +131     
==========================================
+ Hits         1963     2066     +103     
- Misses        276      304      +28     
Files Changed Coverage Δ
src/FrankWolfe.jl 100.00% <ø> (ø)
src/block_coordinate_algorithms.jl 94.87% <94.87%> (ø)
src/alm.jl 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/polytope_oracles.jl Outdated Show resolved Hide resolved
src/polytope_oracles.jl Outdated Show resolved Hide resolved
src/alm.jl Outdated Show resolved Hide resolved
examples/alm.jl Outdated Show resolved Hide resolved
examples/alm.jl Outdated Show resolved Hide resolved
src/alm.jl Outdated Show resolved Hide resolved
@matbesancon
Copy link
Member

For documentation, there should be a new documentation page placed in docs/src/reference/
probably 5_intersection_problems.md, with the same layout as the other ones

src/alm.jl Outdated Show resolved Hide resolved
src/alm.jl Outdated Show resolved Hide resolved
test/alm_tests.jl Outdated Show resolved Hide resolved
src/alm.jl Outdated Show resolved Hide resolved
examples/alm_sdp.jl Outdated Show resolved Hide resolved
@matbesancon matbesancon merged commit b2e6871 into ZIB-IOL:master Aug 7, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants