remove batch_size, make tensor 2D instead of 3D #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix param_vis to fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in #48 ,
-Remove 'batch_size' in exporting onnx file, hence making our onnx file specific to a certain input shape aka an exact number of inputs, which is fine for now, since our witness approach requires us to bake new onnx file for each computation anyway. Also, it seems that ezkl.gen_witness still cannot really handle batch_size with value greater than 1.
-With Batch_size out, we now are able to do everything in 1D tensor, but we decided to make it in 2D aka using reshape(-1,1) instead to make it a lot less computing power for Regression function.