make annotations-optional a KMP library #81
Conversation
| # TODO: remove when updating to Kotlin 2.0 | ||
| kotlin.native.ignoreIncorrectDependencies=true |
There was a problem hiding this comment.
Kotlin 1.x will warn on common compileOnly dependencies even if they are added to the non jvm source sets, 2.0 resolved that.
gabrielittner
force-pushed
the
optional-kmp
branch
from
abda629
to
92c7e2d
Compare
|
Ah, it looks like kotlin-inject with mingw_x64 support doesn't have a release yet. I could revert the last commit and we go with just making the annotations available in KMP. |
|
yeah just revert the windows support for now. Can add it back when kotlin-inject gets around to another release |
|
Can you add a note to the changelog too? |
|
Removed windows and added changelog 👍 |
|
looks like one issue left on CI: https://github.com/ZacSweers/anvil/actions/runs/11616049123/job/32348084558?pr=81#step:5:324 |
|
6be98de should fix it |
|
All green now. I'll open a small follow up after this is merged to make the publishing setup slightly nicer. |
| import me.tatarka.inject.annotations.Qualifier as KotlinInjectQualifier | ||
|
|
||
| /** | ||
| * A class based [qualfier](Qualifier). |
There was a problem hiding this comment.
| * A class based [qualfier](Qualifier). | |
| * A class based [qualifier](Qualifier). |
With this
ForScopeandSingleIncan be used with both Dagger and kotlin-inject. All targets have the kotlin-inject annotations and the jvm target has the javax.inject annotations like before (I've also added jakarta while I was at it).