Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ina237 support #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add ina237 support #88

wants to merge 1 commit into from

Conversation

ftyers
Copy link

@ftyers ftyers commented Feb 15, 2022

Description

This is code to add support for INA237, from @ghcoleman who is working at Grobotic Systems. The code has been tested and works, but I do not have access to the testing environment.

I realise the PR is a bit bare and perhaps based on a version that isn't main. I definitely do not expect it to be merged as is, but I submitted it as it might be useful to someone in the future, for example the author of issue #78.

Fixes #78

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • The changes made link back to an existing issue number

@Limhes
Copy link

Limhes commented Jun 17, 2024

The INA237-specific code in INA_Class::initDevice() does not compile here, because variables are declared after the case label. If the case statements are enclosed in an {} block, then it compiles.

@jonbessette
Copy link

jonbessette commented Sep 10, 2024

The
(RESOLVED BELOW)
Hey Limhes - can you explain in a bit more detail where to place the {} block?

Screenshot 2024-09-10 at 12 47 53 PM

In the .cpp file, at what lines? Sorry, I can't seem to figure it out. Thanks!

@jonbessette
Copy link

jonbessette commented Sep 10, 2024

Screenshot 2024-09-10 at 12 55 41 PM

Heck yeah, figured it out. Literally just as you explained... my apologies on the confusion. Literally after each case INAxxx

src.zip

e.g.
case INA219: add a { at start and } at end of every single one of them.

I included the .zip of the working code with ina237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hi Zanduino, Is it Possible to Integrate the INA237 ? Our requirement is to support 85V .
3 participants