Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PES-1486_phpcs_rules_improvement #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mrakor
Copy link
Contributor

@Mrakor Mrakor commented Jul 21, 2023

solve constatnt spacing with and without annotation
force constructor params on multiline if more than 1
force file comment spacing if present
disallow empty line after class opening brace and before class closing brace
update slevomat package
fix broken Packetery sniffs after slevomat package update

solve constatnt spacing with and without annotation
force constructor params on multiline if more than 1
force file comment spacing if present
disallow empty line after class opening brace and before class closing brace
update slevomat package
fix broken Packetery sniffs after slevomat package update
@@ -1,7 +1,7 @@
{
"require-dev": {
"squizlabs/php_codesniffer": "3.*",
"slevomat/coding-standard": "8.0"
"slevomat/coding-standard": "8.*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nepovoluj prosím jakoukoli verzi 8.x. Může se stát, že si vývojář aktualizuje novější verzi a některé sniffy mu přestanou fungovat - tak jak se to stalo tobě. Zvol konkrétní verzi (která je nyní nejnovější).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants