Applies suggestions from code review

zebra-consensus/src/config.rs

@@ -51,13 +51,16 @@ impl From<Config> for InnerConfig {
     fn from(Config { checkpoint_sync }: Config) -> Self {
         Self {
             checkpoint_sync,
-            ..Default::default()
+            _debug_skip_parameter_preload: false,
         }
     }
 }
 
-/// Inner consensus configuration for backwards compatibility with fields that have been removed.  
-#[derive(Clone, Debug, Eq, PartialEq, Default, Deserialize, Serialize)]
+/// Inner consensus configuration for backwards compatibility with older `zebrad.toml` files,
+/// which contain fields that have been removed.
+///
+/// Rust API callers should use [`Config`].
+#[derive(Clone, Debug, Eq, PartialEq, Deserialize, Serialize)]
 #[serde(deny_unknown_fields, default)]
 pub struct InnerConfig {
     /// See [`Config`] for more details.
@@ -78,3 +81,12 @@ impl Default for Config {
         }
     }
 }
+
+impl Default for InnerConfig {
+    fn default() -> Self {
+        Self {
+            checkpoint_sync: true,
+            _debug_skip_parameter_preload: false,
+        }
+    }
+}

zebra-consensus/src/router.rs

@@ -235,7 +235,7 @@ where
     S: Service<zs::Request, Response = zs::Response, Error = BoxError> + Send + Clone + 'static,
     S::Future: Send + 'static,
 {
-    // Give other tasks priority before spawning the download and checkpoint tasks.
+    // Give other tasks priority before spawning the checkpoint task.
     tokio::task::yield_now().await;
 
     // Make sure the state contains the known best chain checkpoints, in a separate thread.