Returns an error instead of panicking when the relevant chain is empty (

#8883)
ZcashFoundation · Sep 23, 2024 · d6301a6 · d6301a6
1 parent c8280d4
commit d6301a6
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/zebra-state/src/service/check.rs b/zebra-state/src/service/check.rs
@@ -67,9 +67,16 @@ where
         .take(POW_ADJUSTMENT_BLOCK_SPAN)
         .collect();
 
-    let parent_block = relevant_chain
-        .first()
-        .expect("state must contain parent block to do contextual validation");
+    let Some(parent_block) = relevant_chain.first() else {
+        warn!(
+            ?semantically_verified,
+            ?finalized_tip_height,
+            "state must contain parent block to do contextual validation"
+        );
+
+        return Err(ValidateContextError::NotReadyToBeCommitted);
+    };
+
     let parent_block = parent_block.borrow();
     let parent_height = parent_block
         .coinbase_height()