Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(release): Add "wait for a full sync" to the release checklist and ticket template #7612

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

teor2345
Copy link
Collaborator

Motivation

We're testing the state format in CI, but some code paths don't get tested until we do a full sync.

So we need to wait for a full sync between the last state change and the release. (Or run a manual full sync.)

Complex Code or Requirements

It's not clear which code changes can change the state format, so it might be easier just to say "anything in zebra-state or zebra-chain".

Solution

Update the release checklist with this step
Update the release ticket template with this step

Review

Ideally this should be merged before we open the ticket for the next release.

This is for discussion at the Zebra sync.

Reviewer Checklist

  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added A-docs Area: Documentation P-Medium ⚡ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG A-release Area: Zebra releases and release management labels Sep 24, 2023
@teor2345 teor2345 self-assigned this Sep 24, 2023
@teor2345 teor2345 requested a review from a team as a code owner September 24, 2023 22:32
@teor2345 teor2345 requested review from oxarbitrage and removed request for a team September 24, 2023 22:32
@teor2345 teor2345 marked this pull request as draft September 24, 2023 22:32
@teor2345 teor2345 changed the title change(release): Add a state full sync to the release checklist and ticket template change(release): Add "wait for a full sync" to the release checklist and ticket template Sep 25, 2023
@upbqdn upbqdn added the do-not-merge Tells Mergify not to merge this PR label Sep 25, 2023
@teor2345 teor2345 marked this pull request as ready for review September 25, 2023 22:05
@teor2345
Copy link
Collaborator Author

Turns out this is needed anyway, we just found a performance issue right before the release because of an auto-opened full sync ticket #7618.

@upbqdn upbqdn removed the do-not-merge Tells Mergify not to merge this PR label Sep 25, 2023
oxarbitrage
oxarbitrage previously approved these changes Sep 28, 2023
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this changes are needed to the release process so thank you for making them.

I left a few minor optional suggestions, feel free to discard them.

.github/ISSUE_TEMPLATE/release.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE/release-checklist.md Outdated Show resolved Hide resolved
@teor2345
Copy link
Collaborator Author

Thank you for the suggestions!

mergify bot added a commit that referenced this pull request Sep 28, 2023
@mergify mergify bot merged commit 04568d2 into main Sep 28, 2023
69 checks passed
@mergify mergify bot deleted the release-flsync branch September 28, 2023 22:53
@upbqdn upbqdn mentioned this pull request Oct 13, 2023
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation A-release Area: Zebra releases and release management C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants