-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(ui): Enable the progress bar feature by default, but only show progress bars when the config is enabled #7615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-enhancement
Category: This is an improvement
P-Low ❄️
I-usability
Zebra is hard to understand or use
A-diagnostics
Area: Diagnosing issues or monitoring performance
labels
Sep 25, 2023
teor2345
changed the title
change(ui): Enable the progress bar feature by default, but require a config to activate them
change(ui): Enable the progress bar feature by default, and add a config for it
Sep 25, 2023
upbqdn
added
do-not-merge
Tells Mergify not to merge this PR
and removed
do-not-merge
Tells Mergify not to merge this PR
labels
Sep 25, 2023
teor2345
changed the title
change(ui): Enable the progress bar feature by default, and add a config for it
change(ui): Enable the progress bar feature by default, but only show progress bars when the config is enabled
Sep 26, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
teor2345
commented
Oct 5, 2023
arya2
previously approved these changes
Oct 5, 2023
teor2345
added
do-not-merge
Tells Mergify not to merge this PR
and removed
do-not-merge
Tells Mergify not to merge this PR
labels
Oct 5, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
the
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
label
Oct 10, 2023
teor2345
commented
Oct 11, 2023
arya2
approved these changes
Oct 11, 2023
I have done the first task in PR #7610, I'll put the rest in the appropriate Slack channels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-diagnostics
Area: Diagnosing issues or monitoring performance
C-enhancement
Category: This is an improvement
C-feature
Category: New features
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
I-usability
Zebra is hard to understand or use
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
After this PR merges, add:
Motivation
Currently the
progress-bars
feature turns on progress bars and file logging when it is enabled.To make it easier for users to test progress bars, we can make the progress bars configurable with
zebrad.toml
. This allows us to compile theprogress-bar
feature by default, but not activate it for every user by default.(Activating progress bars by default could be a breaking change for some users that expect Zebra to write logs to standard output.)
Close #7363
Close #7364
Complex Code or Requirements
When the progress bar feature is activated, the log file also needs to be activated (unless the user has specifically turned it off).
I added a summary and detailed config, because we might want to have an "expert" mode. But we need to know what users want first!
Solution
progress-bars
feature is enabledprogress-bars
feature by default in Zebra buildsTesting
Review
This is a low priority feature, it doesn't need to go in the 1.3.0 release.
Reviewer Checklist
Follow Up Work
Work out which progress bars users want.