Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(doc): Fix an incorrect consensus-critical ZIP 212 comment #7774

Merged
merged 2 commits into from
Oct 19, 2023
Merged

fix(doc): Fix an incorrect consensus-critical ZIP 212 comment #7774

merged 2 commits into from
Oct 19, 2023

Conversation

teor2345
Copy link
Collaborator

Motivation

This comment is potentially confusing, because the consensus rule reference is wrong.

Review

This is a low priority consensus docs bug.

Reviewer Checklist

  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-bug Category: This is a bug A-docs Area: Documentation P-Low ❄️ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Oct 18, 2023
@teor2345 teor2345 self-assigned this Oct 18, 2023
@teor2345 teor2345 requested a review from a team as a code owner October 18, 2023 22:18
@teor2345 teor2345 requested review from oxarbitrage and removed request for a team October 18, 2023 22:18
@oxarbitrage
Copy link
Contributor

I see some problems in the CI with billing not enabled https://github.com/ZcashFoundation/zebra/actions/runs/6567215057/job/17839508993?pr=7774

I think this might had been temporal so i am running the full workflows again.

oxarbitrage
oxarbitrage approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thanks!

@oxarbitrage
Copy link
Contributor

I think this might had been temporal so i am running the full workflows again.

Didn't help, i now upgraded witth the base branch to see if the errors go away.

@teor2345
Copy link
Collaborator Author

This seems to be an infrastructure issue, I'm just going to restart that job:

get block template / Run get-block-template test
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

https://github.com/ZcashFoundation/zebra/actions/runs/6580053486?pr=7774

@mergify mergify bot merged commit ab3ce9a into main Oct 19, 2023
105 checks passed
@mergify mergify bot deleted the fix-zip-212-doc branch October 19, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

Assignees

@teor2345 teor2345

Labels
A-docs Area: Documentation C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @oxarbitrage